Add context argument to LogRecordProcessor#onEmit #4889
Conversation
Codecov ReportBase: 90.83% // Head: 90.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4889 +/- ##
============================================
+ Coverage 90.83% 90.87% +0.03%
- Complexity 4857 4860 +3
============================================
Files 556 556
Lines 14475 14476 +1
Branches 1410 1411 +1
============================================
+ Hits 13149 13155 +6
+ Misses 908 905 -3
+ Partials 418 416 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
sdk/logs/src/main/java/io/opentelemetry/sdk/logs/LogRecordProcessor.java
Outdated
Show resolved
Hide resolved
|
seems fine if the linked issue is really no longer blocked on spec changes |
|
open-telemetry/opentelemetry-specification#2927 resolves this at the spec level. We discussed having two methods in |
|
open-telemetry/opentelemetry-specification#2927 has been merged and this is now unblocked. |
* Add context argument to LogRecordProcessor#onEmit * Change argument order
Alternative to #4888 which adds context as an argument to processor. This allows context to be garbage collected sooner than with #4888 as described here.
Resolves #4147.